-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi table insert #126
Multi table insert #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! If you have extra time you should add a test for the form component in the testing suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry did not see that the tests did not pass. I spent some time looking at it and I think I know what the problem is, I will highlight it in this review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@A-Baji Nice job in figuring a lot of this out. 💪
Based on this, we can tweak our structure a bit to properly accommodate.
…insertcomponent, store tables better and add connection,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@A-Baji Looking good. 😎
We should add a GET
route for the fields info since the frontend will need this. This is necessary so we can map between the display and what the database needs. I've updated the issue with specifications. Could you look into that next?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@A-Baji Great job! 👍 Can see a well thought-out approach here.
Have some additional points for consideration in your algorithm approach. I actually have an example to share that can help you improve on all of these. 🤓
Oh, and what if I could tell you we could get the following as a bonus too?
- Allows multiple inserts to be submitted
- Configuration can omit individual maps if no change
- Configuration can omit
map
fromtable
maps if no change - slightly less code
Find me and we can knock this out in a tagup together.
Allow multiple submissions, maps are now individually optional.
No description provided.