-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update carlos pr #128
Update carlos pr #128
Conversation
Supersedes #127 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Thanks @jverswijver @zitrosolrac! 👏 This is looking great and DS team is looking forward to it.
Just have a few remaining items to clear up before we are ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jverswijver Thanks for refactoring to address the distinct fields included in the attributes. 🤝
There was some feedback from my last review that is still unresolved. Providing additional feedback here from the new review. Let me know if you have any questions or concerns.
Co-authored-by: Raphael Guzman <38401847+guzman-raphael@users.noreply.github.com>
@guzman-raphael ended up figuring out why the |
remove force get_json
restriction query parameter handling and test
add the final touches to #127 since @zitrosolrac is unavailable