Update forms to enable presets #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Baji
reviewed
Mar 16, 2023
guzman-raphael
requested changes
Mar 20, 2023
There was a problem hiding this comment.
@jverswijver Looks great! 🤝
Would you just rename the new property in the spec please? Think this matches the rest of the theme better.
Comment on lines
97
to
99
| preset_function: > | ||
| def preset_function(): | ||
| return {'preset 1': {'b_id': 14}} |
There was a problem hiding this comment.
Can we update this to the following? I think it is a bit cleaner.
Suggested change
| preset_function: > | |
| def preset_function(): | |
| return {'preset 1': {'b_id': 14}} | |
| presets: > | |
| def presets(): | |
| return {'preset 1': {'b_id': 14}} |
guzman-raphael
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.