Clean up type errors, minor bugs, edge cases #95

bdewilde · 2023-12-20T02:55:46Z

standardize + improve error handling in api and app
remove special handling for errors in api endpoints; let the error handlers handle it! that's their job
refactor many db queries so that the conversion into dictionaries is explicit rather than subtle and implicit; code is now more verbose but much clearer what's happening (and mypy doesn't complain)
fix many typing / linting complaints, as well as some edge case bugs
add more type annotations to db models

now handled automatically by error handler

i hope this is right ....

bdewilde added 11 commits December 19, 2023 20:27

feat: Standardize app errors somewhat

3ae1b88

feat: Simplify error logic in users api

333e3ea

now handled automatically by error handler

fix: Prevent unbound variable error

8adfdda

lint: Add type guards to help checker

9e66230

refactor: Tweak db code to avoid typing errors

0e9aa8f

feat: Add type hints to some json db cols

01e573a

feat: Make implicit db data munging explicit

00b4447

feat: Add more type guards, lint cleanups

ae2e7ad

fix: Catch more type / sa v2 bugs

4ff536f

feat: Handle db integ error w/ diff handler

117dc9b

feat: Remove special db integ err handling in api

928f583

bdewilde marked this pull request as ready for review December 21, 2023 02:01

bdewilde added 3 commits December 20, 2023 21:03

fix: Type in db query, woof

e36d5ca

fix: The same typo, elsewhere

c9c9b46

fix: Give two db cols optional annots

0a71d54

i hope this is right ....

bdewilde merged commit 8ca9d4b into develop Dec 21, 2023
3 checks passed

bdewilde deleted the burton-tidy-more-loose-ends branch December 21, 2023 02:19

Provide feedback