Enhance debug logging

datakurre · Sep 22, 2023 · 47f24f9 · 47f24f9
1 parent 7961160
commit 47f24f9
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/Makefile.release b/Makefile.release
@@ -1,5 +1,5 @@
 ARTIFACT_NAME = camunda-rcc-worker
-ARTIFACT_VERSION ?= 0.8.2-3
+ARTIFACT_VERSION ?= 0.8.2-4
 ARTIFACT_FULLNAME ?= $(ARTIFACT_NAME)-$(ARTIFACT_VERSION).tar.gz
 REPOSITORY ?= nomad-local
 

diff --git a/carrot_rcc.ts b/carrot_rcc.ts
@@ -729,9 +729,11 @@ const subscribe = (topic: string) => {
 
     try {
       // Prepare robot
+      LOG.debug("Preparing task", task.topicName, task.id);
       const files = await load(task, tasksDir, itemsDir, topic);
 
       // Execute robot
+      LOG.debug("Executing task", task.topicName, task.id);
       await new Promise((resolve, reject) => {
         const stdout: string[] = [];
         const stderr: string[] = [];
@@ -770,6 +772,7 @@ const subscribe = (topic: string) => {
           LOG.debug(data.toString());
         });
         exec.on("close", async (code) => {
+          LOG.debug("Executing task exit code", code, task.topicName, task.id);
           let errorMessage = "error";
           if (code !== null && code > 0 && code < 251) {
             errorMessage = await failReason(tasksDir);
@@ -784,12 +787,15 @@ const subscribe = (topic: string) => {
               stderr.join(""),
               code || 0
             );
+            LOG.debug("Result collection completed", task.topicName, task.id);
           } catch (e) {
+            LOG.debug("Result collection failed", task.topicName, task.id);
             LOG.error(`${e}`);
             stderr.push(`${e}`);
             code = 255; // Unexpected error
           }
           if (code === 0) {
+            LOG.debug("Completing task...", task.topicName, task.id);
             const relpath = path.join(itemsDir, "items.release.json");
             const release = fs.existsSync(relpath)
               ? JSON.parse(fs.readFileSync(relpath) as unknown as string)
@@ -804,13 +810,23 @@ const subscribe = (topic: string) => {
                   release?.exception?.type === "BUSINESS"
                 ) {
                   // RPA.Robocorp.WorkItems.Release with business error
+                  LOG.debug(
+                    "Completing task with business error",
+                    task.topicName,
+                    task.id
+                  );
                   await taskService.handleBpmnError(
                     task,
                     release?.exception?.code || null,
                     release?.exception?.message || null
                   );
                 } else if (release?.state === "FAILED") {
                   // RPA.Robocorp.WorkItems.Release with application error
+                  LOG.debug(
+                    "Completing task with technical failure",
+                    task.topicName,
+                    task.id
+                  );
                   await taskService.handleFailure(task, {
                     errorMessage:
                       release?.exception?.code ||
@@ -821,9 +837,15 @@ const subscribe = (topic: string) => {
                     retryTimeout,
                   });
                 } else {
+                  LOG.debug(
+                    "Completing task with success",
+                    task.topicName,
+                    task.id
+                  );
                   await taskService.complete(task);
                 }
               } catch (e) {
+                LOG.debug("Completing task failed", task.topicName, task.id);
                 LOG.error(`${e}`);
                 stderr.push(`${e}`);
                 code = 255; // Unexpected error
@@ -881,6 +903,7 @@ const subscribe = (topic: string) => {
         });
       });
     } catch (e: any) {
+      LOG.debug("Completed task with failure", task.topicName, task.id);
       LOG.debug(e);
       await taskService.handleFailure(task, {
         errorMessage: `${e?.error?.message ?? e}`,