Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incrementally enable more ruff rules #971

Open
ml-evs opened this issue Oct 28, 2024 · 2 comments
Open

Incrementally enable more ruff rules #971

ml-evs opened this issue Oct 28, 2024 · 2 comments
Assignees
@be-smith
Labels
priority/low Python refactoring For issues/PRs that refactor existing code/features

Comments

@ml-evs
Copy link
Member

ml-evs commented Oct 28, 2024

In #970, I found the flake8-datetimez/ruff rules very helpful for best practices linting; we should look through https://docs.astral.sh/ruff/rules and decide if there are any others we would like to enable.
@ml-evs ml-evs added refactoring For issues/PRs that refactor existing code/features priority/low Python labels Oct 28, 2024
@ml-evs
Copy link
Member Author

ml-evs commented Mar 11, 2025

e.g., lets turn on https://docs.astral.sh/ruff/rules/logging-string-format/#logging-string-format-g001

@ml-evs
Copy link
Member Author

ml-evs commented Mar 11, 2025

also: let's make sure that pyupgrade is keeping us above Python 3.10 -- in pre-commit config, add arg for --py310-plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@be-smith be-smith

Labels
priority/low Python refactoring For issues/PRs that refactor existing code/features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ml-evs @be-smith