-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone consistency across deployments & UI #970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
Project |
datalab
|
Branch Review |
ml-evs/datetime-fixes
|
Run status |
|
Run duration | 06m 11s |
Commit |
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
405
|
View all changes introduced in this branch ↗︎ |
5493a64
to
f29eae3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 68.42% 68.43% +0.01%
==========================================
Files 62 62
Lines 3933 3935 +2
==========================================
+ Hits 2691 2693 +2
Misses 1242 1242
|
f29eae3
to
f7cd422
Compare
f7cd422
to
853f82d
Compare
ml-evs
commented
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix the issue you were seeing @BenjaminCharmes, was just some overzealous refactoring
dd330e6
to
618290c
Compare
- Enable DTZ (flake8-datetimez) rules in ruff - Update test cases to use tz where needed - Add any missing timezone info when remote filesystem syncing
- Update custom datetime to add any missing timezone - Fix: datetime wrapper should not make up a new JSONSchema type - Use extended datetime for `time_added` in `File` model
Remove now-unnecessary timezone workaround in app Update app test with UTC offset Fix app bug introduced during refactor Add specific handling of datetime fields in computed getters/setters Use localized timestamp in UI, thanks to Sweden Fix UI date display when updated in starting_materials EditPage
618290c
to
606408e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces UTC for all datetimes stored by datalab, via:
00:00
UTC offset suffix.<input format='datetime-local'>
into the full isoformat stamp.Closes #440
Assorted fixes:
IsoformatDateTime
wrapper was also setting a bad JSON Schema type, for some reason -- this is removedFile
model wasn't using the extended datetime format fortime_added
.Relatedly (from HN today...): https://ssoready.com/blog/engineering/truths-programmers-timezones/