Switch from vue-cli to vite #1026
Draft
+2,158
−6,773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminCharmes
force-pushed
the
bc/switch-to-vite
branch
from
695e0a4 to
1222921
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 70.04% 70.04%
=======================================
Files 62 62
Lines 3996 3996
=======================================
Hits 2799 2799
Misses 1197 1197 |
BenjaminCharmes
added
enhancement
BenjaminCharmes
force-pushed
the
bc/switch-to-vite
branch
from
52e306e to
5cbd538
Compare
BenjaminCharmes
force-pushed
the
bc/switch-to-vite
branch
from
42814f6 to
7bb9e9f
Compare
BenjaminCharmes
added
the
build
BenjaminCharmes
force-pushed
the
bc/switch-to-vite
branch
2 times, most recently
from
da60bee to
5a7a0d7
Compare
First attempt to switch from vue-cli to vite Remove a 'process' that I missed Fix a few thing to make vite work Fix a few thing to make vite work Fix a few thing to make vite work Downgrade Bokeh to 2.4.0 Downgrade tinymce to v5 Temp commit Update yarn build with vite Update yarn build with vite Update yarn build with vite Update yarn build with vite Update docker build for vite Add serve into package.json Update env variable fron VUE_ to VITE_
BenjaminCharmes
force-pushed
the
bc/switch-to-vite
branch
from
2fa241e to
ba6115f
Compare
ml-evs
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1005
First attempt to switch from vue-cli to vite and a few things to discuss:
I had to use
cryptojsinstead ofcrypto(MD5(value).toString();instead ofcrypto.createHash("md5").update(value).digest("hex");)I had to use
import.meta.env.BASE_URLinstead ofprocess.env.BASE_URLI remove
.browserslistrcandbabel.config.js, not useful with vite ?vite 6.x.xnot supported bycypress? (warning message)In
vite.config.js, I useextensions: [".vue", ".js", ".json"]to not rename all the imports in all the files, but it could be better to take the time to do it ? (e.g.import Navbar from "@/components/Navbar";toimport Navbar from "@/components/Navbar.vue";Had to rename env variables from
VUE_toVITE_to make it work without having to import all of them. Should we keep it that way (and also rename them where ever it's needed, e.g. github?) or just import them in the vite.config.js ?To do:
package.json?Bokeh.Just need to downgrade to Bokeh 2.4.0
import "tinymce/plugins/hr";not workingDowngrade tinymce to v5