Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loading state for data-intensive blocks #1049

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Improve loading state for data-intensive blocks #1049

wants to merge 2 commits into from

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #1045

First attempt to improve the loading state for data-intensive blocks

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (f58a5ed) to head (74b7fe1).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   68.49%   70.04%   +1.54%     
==========================================
  Files          62       62              
  Lines        3955     3996      +41     
==========================================
+ Hits         2709     2799      +90     
+ Misses       1246     1197      -49

see 6 files with indirect coverage changes

@BenjaminCharmes BenjaminCharmes added enhancement New feature or request webapp For issues/PRs pertaining to the web interface datablock An issue pertaining to a specific datablock labels Feb 20, 2025
@cypress Cypress
Copy link

cypress bot commented Feb 20, 2025 •
edited
Loading

datalab    Run #2921

Run Properties:  status check passed Passed #2921  •  git commit e48b4143de ℹ️: Merge 74b7fe1b6f3ec04bfdf60a2e7c011a0579983d34 into 17ab3575328038e4dc200814c5a3...
Project datalab
Branch Review bc/block-loading
Run status status check passed Passed #2921
Run duration 06m 34s
Commit git commit e48b4143de ℹ️: Merge 74b7fe1b6f3ec04bfdf60a2e7c011a0579983d34 into 17ab3575328038e4dc200814c5a3...
Committer Ben Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly will be requested when the pull request is marked ready for review jdbocarsly is a code owner

@ml-evs ml-evs Awaiting requested review from ml-evs ml-evs will be requested when the pull request is marked ready for review ml-evs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
datablock An issue pertaining to a specific datablock enhancement New feature or request webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better loading state for blocks
1 participant
@BenjaminCharmes