Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay while deleting multiple items #1054

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #944

Add an overlay while deleting multiple items to prevents the user from interrupting the process.

@BenjaminCharmes BenjaminCharmes force-pushed the bc/loading-state-deleting branch from 0dc8d6f to 6f0f700 Compare February 21, 2025 15:51
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (b933fdb) to head (fae6a8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files          63       63           
  Lines        4087     4087           
=======================================
  Hits         2864     2864           
  Misses       1223     1223           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenjaminCharmes BenjaminCharmes added webapp For issues/PRs pertaining to the web interface usability labels Feb 21, 2025
Copy link

cypress bot commented Feb 21, 2025

datalab    Run #2984

Run Properties:  status check passed Passed #2984  •  git commit bee3c42a59 ℹ️: Merge fae6a8c86d51414e75ff169b6f2106032454db3e into b933fdb05e30a0dadc0455909283...
Project datalab
Branch Review bc/loading-state-deleting
Run status status check passed Passed #2984
Run duration 07m 11s
Commit git commit bee3c42a59 ℹ️: Merge fae6a8c86d51414e75ff169b6f2106032454db3e into b933fdb05e30a0dadc0455909283...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the bc/loading-state-deleting branch from 6f0f700 to 1851956 Compare February 25, 2025 21:12
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review February 26, 2025 09:52
@ml-evs ml-evs requested a review from be-smith March 11, 2025 15:02
@be-smith be-smith force-pushed the bc/loading-state-deleting branch from 1851956 to fae6a8c Compare March 19, 2025 15:30
Copy link
Contributor

@be-smith be-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Tested locally works well :)

@be-smith be-smith merged commit e11ef6a into main Mar 19, 2025
17 checks passed
@be-smith be-smith deleted the bc/loading-state-deleting branch March 19, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting multiple items should have accompanying loading state
2 participants