Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ftir block and associated tests #1061

Merged
merged 6 commits into from
Mar 15, 2025
Merged

added ftir block and associated tests #1061

merged 6 commits into from
Mar 15, 2025

Conversation

be-smith
Copy link
Contributor

Created an FTIR block to plot data from the .asp file format to plot absorbance vs wavenumber for FTIR data.

Tests have been written to make sure a plot is produced and the resultant data has the expected dimensions and the peak at ~1000 cm-1 has the correct height.

Screenshot 2025-03-10 at 13 02 39

Copy link

cypress bot commented Mar 10, 2025

datalab    Run #2977

Run Properties:  status check passed Passed #2977  •  git commit 952248a100 ℹ️: Merge 7fa5ca353542ce737b7433cb14dfc7605823b32c into 81beb95f5b505ca74826aebb522f...
Project datalab
Branch Review ftir-block
Run status status check passed Passed #2977
Run duration 06m 44s
Commit git commit 952248a100 ℹ️: Merge 7fa5ca353542ce737b7433cb14dfc7605823b32c into 81beb95f5b505ca74826aebb522f...
Committer Ben Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 157
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 69.38776% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (81beb95) to head (7fa5ca3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/ftir/__init__.py 68.75% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
+ Coverage   69.98%   70.07%   +0.09%     
==========================================
  Files          62       63       +1     
  Lines        4038     4087      +49     
==========================================
+ Hits         2826     2864      +38     
- Misses       1212     1223      +11     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/blocks/__init__.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/apps/ftir/__init__.py 68.75% <68.75%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@be-smith be-smith linked an issue Mar 10, 2025 that may be closed by this pull request
8 tasks
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few initial comments, we can talk through tomorrow if helpful

@be-smith be-smith marked this pull request as ready for review March 14, 2025 15:34
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @be-smith!

@ml-evs ml-evs added enhancement New feature or request datablock An issue pertaining to a specific datablock labels Mar 15, 2025
@ml-evs ml-evs merged commit e5f3f28 into main Mar 15, 2025
39 of 45 checks passed
@ml-evs ml-evs deleted the ftir-block branch March 15, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datablock An issue pertaining to a specific datablock enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for FTIR data
2 participants