-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ftir block and associated tests #1061
Conversation
datalab
|
Project |
datalab
|
Branch Review |
ftir-block
|
Run status |
|
Run duration | 06m 44s |
Commit |
|
Committer | Ben Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
157
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 69.98% 70.07% +0.09%
==========================================
Files 62 63 +1
Lines 4038 4087 +49
==========================================
+ Hits 2826 2864 +38
- Misses 1212 1223 +11
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few initial comments, we can talk through tomorrow if helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @be-smith!
Created an FTIR block to plot data from the .asp file format to plot absorbance vs wavenumber for FTIR data.
Tests have been written to make sure a plot is produced and the resultant data has the expected dimensions and the peak at ~1000 cm-1 has the correct height.