-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concept of user groups #1062
Draft
ml-evs
wants to merge
7
commits into
main
Choose a base branch
from
ml-evs/user-groups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
+ Coverage 69.98% 70.26% +0.28%
==========================================
Files 62 63 +1
Lines 4038 4140 +102
==========================================
+ Hits 2826 2909 +83
- Misses 1212 1231 +19
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
ml-evs/user-groups
|
Run status |
|
Run duration | 06m 48s |
Commit |
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
471
|
View all changes introduced in this branch ↗︎ |
8f3071c
to
5da5920
Compare
5da5920
to
34d5719
Compare
4806a68
to
4123e7b
Compare
44e7058
to
92424a1
Compare
92424a1
to
eae5cdf
Compare
d56a0ab
to
6d01fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the concept of groups of users, and the corresponding API routes and UIs. The aim of groups is to be able to provide blanket permissions to subsets of users. Some statements:
Still to-do: