Added support for rasx xrd files #1067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 70.07% 70.18% +0.10%
==========================================
Files 63 63
Lines 4087 4105 +18
==========================================
+ Hits 2864 2881 +17
- Misses 1223 1224 +1
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/xrd-rasx
|
| Run status |
|
| Run duration | 08m 11s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
added
enhancement
…the accepted extensions for xrd block
ml-evs
requested changes
Mar 19, 2025
Comment on lines
+169
to
+173
| data_file = None | ||
| for file in destination.glob("Data*/*.txt"): | ||
| data_file = file | ||
| break | ||
|
|
There was a problem hiding this comment.
I think here we should emit a warning if there are extra data folders or txt files. You can use warnings.warn("<message>") and it will show up in the block UI for the user. Just say something like "only / was used, but others were found."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for .rasx (.rasx.zip) xrd files from the Rigaku diffractometer.