Add support for XRD files that have indeterminate headers (e.g., diffrac.eva export) #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 68.22% 68.34% +0.12%
==========================================
Files 62 62
Lines 3909 3921 +12
==========================================
+ Hits 2667 2680 +13
+ Misses 1242 1241 -1
|
ml-evs
force-pushed
the
ml-evs/bruker-evadiffract
branch
from
d72afe6 to
95cc09d
Compare
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/bruker-evadiffract
|
| Run status |
|
| Run duration | 11m 03s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
| View all changes introduced in this branch ↗︎ | |
jdbocarsly
requested changes
Oct 3, 2024
ml-evs
force-pushed
the
ml-evs/bruker-evadiffract
branch
from
3f4965e to
7387b8e
Compare
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #903 by trying to load xy/xye files iteratively, ignoring any lines that do not fit the expect number of floats (and crashing out if the header is more than 10,000 lines).
cc @jmas5
Probably one for @jdbocarsly to check with some of his group's files to make sure nothing breaks (I added test cases, but you never know...)