Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up custom primevue theme #921

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Set up custom primevue theme #921

merged 4 commits into from
Oct 15, 2024

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Oct 11, 2024 •
edited
Loading

Setting up a custom theme for primevue instead of applying global css to primevue components

  • Set transition time to 0.05s (default: 0.2s)
  • Set the padding of datatable headers and cells to 0.5rem (default: offset between header and bodycell)
  • Hides the sorting icon until the header is hovered
  • Make the text in the cells appear on a single line (nowrap and overflow hidden)
  • Make the filter icon change color when a filter is active
  • Checkboxes color grey

@ml-evs ml-evs added this to the v0.6.x milestone Oct 14, 2024
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 15, 2024 13:26
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (2f3dfb2) to head (c08991a).
Report is 83 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files          62       62           
  Lines        3928     3928           
=======================================
  Hits         2686     2686           
  Misses       1242     1242

@cypress Cypress
Copy link

cypress bot commented Oct 15, 2024 •
edited
Loading

datalab    Run #2571

Run Properties:  status check passed Passed #2571  •  git commit 13efdc80f6 ℹ️: Merge 99e26225d841c835ac74a547b052d67459e62fd6 into 4054f520ccf4969a07efcc8cf5d0...
Project datalab
Run status status check passed Passed #2571
Run duration 06m 56s
Commit git commit 13efdc80f6 ℹ️: Merge 99e26225d841c835ac74a547b052d67459e62fd6 into 4054f520ccf4969a07efcc8cf5d0...
Committer Benjamin Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396

@BenjaminCharmes
Add a custom preset primevue theme
5277fb2 
Update custom primevue theme

Update custom primevue theme

change transitionDuration to 0.05s

Fix padding diff between header and body cell
@BenjaminCharmes BenjaminCharmes force-pushed the bc/custom-prime-theme branch 2 times, most recently from 8eb1f55 to 5277fb2 Compare October 15, 2024 16:05
jdbocarsly
jdbocarsly approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@jdbocarsly jdbocarsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! This will be really helpful to have, and its nice that it cleans up the css on the datatable component as well

ml-evs
ml-evs approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (and feels) great at my end, thanks @BenjaminCharmes!

@ml-evs ml-evs enabled auto-merge (squash) October 15, 2024 18:12
@ml-evs ml-evs added enhancement New feature or request webapp For issues/PRs pertaining to the web interface visuals For issues/PRs pertaining to visuals/aesthetics of the interface javascript Pull requests that update Javascript code labels Oct 15, 2024
@ml-evs ml-evs modified the milestones: v0.6.x, v0.5.x Oct 15, 2024
@ml-evs ml-evs merged commit 83f52b7 into main Oct 15, 2024
17 checks passed
@ml-evs ml-evs deleted the bc/custom-prime-theme branch October 15, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@jdbocarsly jdbocarsly jdbocarsly approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request javascript Pull requests that update Javascript code visuals For issues/PRs pertaining to visuals/aesthetics of the interface webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminCharmes @ml-evs @jdbocarsly