Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken meta data in HTML after #367? #379

Closed
adswa opened this issue Feb 6, 2020 · 2 comments · Fixed by #380
Closed

Broken meta data in HTML after #367? #379

adswa opened this issue Feb 6, 2020 · 2 comments · Fixed by #380

Comments

@adswa
Copy link
Contributor

adswa commented Feb 6, 2020

It appears as if #367 (it introduced section numbering) also introduced a meta property HTML tag that seems to be broken and results in this:

image

@adswa
Copy link
Contributor Author

adswa commented Feb 7, 2020

Interestingly, I can't replicate the broken meta property tag locally. If I build the html files locally from the current master, the meta tag is fine:

  <meta property="og:title" content="1. Create a dataset &#8212; The DataLad Handbook">

The version build by read the docs however produces this broken tag (note the tag around the section number):

  <meta property="og:title" content="<span class="section-number">1. </span>Create a dataset &#8212; The DataLad Handbook">

@adswa
Copy link
Contributor Author

adswa commented Feb 7, 2020

I verified that the problem comes with Sphinx 2.3.1, which readthedocs uses by default: I upgraded from Sphinx 2.1.2 to Sphinx 2.3.1 and now have the broken meta property tag as well when I build the handbook locally.

adswa added a commit that referenced this issue Feb 7, 2020
I'm hoping to convince readthedocs to build the html
handbook with a non-most-recent Sphinx version. With
Sphinx 2.3.1 as currently used by RTD, #379 happens
adswa added a commit that referenced this issue Feb 17, 2020
Pin Sphinx version for readthedocs to prevent #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant