Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failed, probable dependency version conflict #821

Closed
mslw opened this issue Apr 7, 2022 · 1 comment · Fixed by #827
Closed

Build failed, probable dependency version conflict #821

mslw opened this issue Apr 7, 2022 · 1 comment · Fixed by #827

Comments

@mslw
Copy link
Collaborator

mslw commented Apr 7, 2022

The latest monthly link check failed with:

ImportError: cannot import name 'environmentfilter' from 'jinja2' (/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/site-packages/jinja2/__init__.py)

Google leads to this issue in Sphinx which says that deprecations in Jinja2 are the cause. Suggested workaround is to pin jinja2 < 3.1 (consistent with the fact that the failed build used 3.1.1, while the last successful used 3.0.3). A proper fix would be to unpin Sphinx itself (currently we have sphinx==2.1.2) and use the latest version, currently 4.5 (which is a big leap).

If readthedocs build fail too, we will need to pin Jinja2, and maybe consider updating Sphinx later on.
@mslw mslw mentioned this issue Apr 7, 2022
Closed
@mslw
Copy link
Collaborator Author

mslw commented Apr 8, 2022

Yes, this repeated for handbook build on github actions after a recent PR. Read the docs builds seems unaffected.

The corresponding RTD build succeeded and the handbook has recent changes. Could be because on RTD we use python 3.7 (specified in .readthedocs.yaml) and that affects installed libraries, but I'm not sure.

adswa added a commit that referenced this issue Apr 13, 2022
@adswa
Drop Sphinx version pinning, but introduce one for Jinja2 following #821
c441759
@adswa adswa mentioned this issue Apr 13, 2022
Merged
@adswa adswa linked a pull request Apr 13, 2022 that will close this issue
Remove version pinning of Sphinx #827
Merged
adswa added a commit that referenced this issue Jan 30, 2024
@adswa
Remove Jinja2 version pinning
b068f74 
It was introduced in response to #821,
but the underlying issue seems resolved (no import error during linkcheck).
An upgrade is necessary because of a vulnerability report in Jinja2, which was
patched in version 3.1.3.
Vulnerability report: https://github.com/datalad-handbook/book/security/dependabot/1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove version pinning of Sphinx datalad-handbook/book
1 participant
@mslw