Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #1243

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Fix some typos #1243

merged 7 commits into from
Jan 3, 2025

Conversation

malikwirin
Copy link
Contributor

@malikwirin malikwirin commented Dec 24, 2024

fixed some smaller typos and a bigger one where a false path caused some confusion for me while reading the book.

Copy link

welcome bot commented Dec 24, 2024

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Wohoo! 🎉 Thanks for opening your first pull request to the DataLad Handbook! 😎 We really appreciate your time and effort to contribute to the project - you're amazing! 👏

@malikwirin malikwirin changed the title FIx Typo Fix some typos Dec 30, 2024
Copy link
Contributor

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, it is much appreciated! I approve, though the last commit needs to be dropped or modified before I can merge (see my comment)

docs/basics/101-123-config2.rst Outdated Show resolved Hide resolved
@adswa
Copy link
Contributor

adswa commented Dec 31, 2024

@all-contributors please add @malikwirin for bug

@malikwirin feel free to add yourself to the .zenodo.json file of this repository, at the second to last position, before "Michael Hanke" (or leave Name, and optionally Orcid and affilliation in a comment, and I'll add you)

Copy link
Contributor

@adswa

I've put up a pull request to add @malikwirin! 🎉

option/options was in plural together with a verb in singular.
in the paragraph above option was also singular. So this brings consistency
@malikwirin malikwirin requested a review from adswa January 3, 2025 17:12
Copy link
Contributor

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much!

@adswa adswa merged commit 13e7a8f into datalad-handbook:main Jan 3, 2025
3 checks passed
Copy link

welcome bot commented Jan 3, 2025

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@malikwirin malikwirin deleted the patch-1 branch January 4, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants