Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Replace inaccurate description of push behavior #482

Merged
merged 1 commit into from
May 14, 2020
Merged

BF: Replace inaccurate description of push behavior #482

merged 1 commit into from
May 14, 2020

Conversation

adswa
Copy link
Contributor

@adswa adswa commented May 9, 2020

As described in #481, the previous description of how push
behaves in datasets with multiple branches was inaccurate,
and resulted from my explorations of push with an explicitly
configured dataset. This change rectifies this, and instead
shows how to configure datasets such that more than just the
current branch is pushed. Fixes #481.

I would appreciate if someone could double check. :)

As described in #481, the previous description of how push
behaves in datasets with multiple branches was inaccurate,
and resulted from my explorations of push with an explicitly
configured dataset. This change rectifies this, and instead
shows how to configure datasets such that more than just the
current branch is pushed. Fixes #481.
Copy link
Collaborator

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyleam This looks good to me. At least for now. It feels as if the exact behavior of push is still subject to changes (in the nearish future).

@mih mih merged commit 4e21f10 into master May 14, 2020
@mih mih deleted the bf-push branch May 14, 2020 18:15
@kyleam
Copy link
Contributor

kyleam commented May 14, 2020

@adswa Thanks for adjusting the text.

Sorry I didn't provide feedback even though this has been open for a while. While I do fetch this repo every so often and glance through all the nice additions, I'm not "watching" it, so I didn't get an email about this. With how I intake information from GitHub, that means I didn't know this PR existed :(

@adswa
Copy link
Contributor Author

adswa commented May 16, 2020

Whoops, sorry for not responding for two days already, too, @kyleam! No worries, I should have tagged you if I wanted to ask for explicit feedback. I remember thinking "It's a Saturday, and it concerns a command that isn't even released yet, so why rush/bother others". I promise that if I would appreciate feedback on something I will tag you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate description of how push handles multiple branches
3 participants