-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make readers aware of broken-symlink-and-BIDS-validator-issues #562
Conversation
Message to past Rémi: "RTFM or to be more precise just even read the --help section of a command!!" Turns out that the command line bids validator has a couple of ways to "get around" this issue but I think it would be worth putting them in the datalad handbook. Let me know if you think that some of this should be added in the sections you created. All the following were done on a valid BIDS dataset that has been dataladed (dataladified? datalified?) but with all annexed files dropped. the badThe following will make the bids-validator scream
the sort of good that doesn't work but tries to helpThe following will "work"
But you will get the extra message:
the ugliesContrary to the previous message using This fails:
the goodThe following actually worked:
|
Ha, thanks for following up on this! Maybe also I should have RTFM ;-) That's very useful information. Feel free to add it in, else I'll do it later today after a streak of video calls. Thank you! |
Won't have time to do the edits that quickly. 💨 I will let you do the honors. |
[an overly polite clarification ensues to overcome the inevitable deficiencies of communicating online instead of face-to-face] Didn't mean to rush you. I can also wait, if you want to do it. I wouldn't mind doing it myself, or waiting, so just stop me if you want to take a whack at it :) |
hahaha I did not feel like you were being pushy 😄 Just wanted to let you know. And also my 2 hands are so full, I wish I were a Hindu deity to help me make progress on this many fronts. So I just wanted to say, I would not be able to make a decent addition very soon. |
cool, got it :) thx |
Re the bids validator not informative error message, see https://github.com/bids-standard/bids-validator/issues/792 The problem though is a bit less benign -- bids-validator is used as a initial step in many bids apps. Some do not have an option yet to skip it (e.g PeerHerholz/BIDSonym#35) . And also it might be .json etc files which are also annexed so ignoring niftis would not be sufficient -- I am getting ORPHANED_SYMLINK on scans.tsv . Filed: https://github.com/bids-standard/bids-validator/issues/1050 |
Some short PR's have been open for a really long while now. Given no-one complained, I will merge them. |
Fixes #560 with an explicit FAQ on the BIDS validator and a more general note on troubles with broken symlinks for some tools.