-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards more user-friendliness for Windows Users #588
Conversation
wget isn't pre-installed on most windows systems, and installing it involves adjusting the PATH. May be easier to just go with curl
Unlike on Unix, Windows can linebreak a command with backslashes. One either needs to copy the command as one line, or use the ^ character instead of the slash
The escape sequences in the here doc make it fail when copy-pasted into a script
At least on my Windows machine, the git log -p output is very long, confusing, and fails to only display the most recent commits.
Given the adjusted branch handling, all files will show up as being changed, which is not useful at all for a user
This returns the same history as the one reported by the handbook, without the adjusted branch commits
Windows has a native convert command that would be used instead and throw 'invalid option' errors
…on windows anyway
…ectories, and also hidden ones
@mih it would be nice if we could chat about installation recommendations. |
This is quite substantial, and yet far from done. I'm sure that much more can and will be done to support Windows users, but this chunk is ready to go in from my point of view. @mih, I've written the "So ... Windows... eh?" page you asked for, and it is here: https://datalad-handbook--588.org.readthedocs.build/en/588/intro/windows.html#ohnowindows ;-) Not sure whether it is what you had in mind, please check. |
In this PR (among many other things) I am switching recommendations about where to install git-annex under Windows -- instead of installing Git via conda-forge (which we recommended to get I also wrote a section on overthinking installation on Windows, but I would be reluctant to merge this without no-one else having had a chance to look at it: https://datalad-handbook--588.org.readthedocs.build/en/588/intro/windows.html#ohnowindows. Feedback would be really appreciated! |
What error exactly? About assistant? |
oh well, a proper long term resolution to windows installation problems would be to build git-annex in conda-forge for windows (conda-forge/git-annex-feedstock#15), and IMHO would be the most effective investment of time (even though might take longer than writing documentation outlining how things do not work, no pun intended whatsoever). The dances with forcing annex into anaconda environment and then changing installed files sure thing cannot be relied on just prolong the pains IMHO, even if @joeyh agrees to make git-annex become more robust in such heterogeneous installations to use system-wide (not conda's) git: https://git-annex.branchable.com/bugs/old__40__er__41___cp_from_coreutils_lacks_--reflink/#comment-9819622af7c173000af5c8337dee4b10 . |
Trying this out right now. Impulse response: Switching away from the conda install for git is an immediate monster-win for a windows noob like me. The Git installer leaves a really nicely configured system behind (TT fonts, symlinks, performance tuning) -- all stuff that I would have had to discover otherwise, and probably would have given up on long before reaching this state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First set of comments after replicating the new installation instructions in win10. Much better!!
docs/intro/installation.rst
Outdated
Please make sure to download and install it. | ||
Please also make sure that it is available in your ``PATH`` environment variable: ``Environment Variables`` -> ``User Variables`` -> ``path`` -> ``edit`` -> ``new`` -> add the path: ``C:\ProgramFiles\7-zip``) -> ``OK``. Lastly, within ``C:\ProgramFiles\7-zip``, copy the ``7z.exe`` file into ``C:\Users\<user>\Miniconda3\Library\usr\bin\``. | ||
- Many Unix command-line tools such as ``cp`` or ``tree`` are not available by default. | ||
You can get a good set of tools by installing :term:`conda`\s ``m2-base`` package via ``conda install m2-base`` in an Anaconda prompt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the git installer I chose to use an msys terminal by default. The resulting environment had tree
, but did not have cp
. Maybe remove tree
in the text to avoid "I can get away with this alternative approach" scenarios.
docs/intro/installation.rst
Outdated
|
||
Note: Is has to be from ``conda-forge``, the anaconda version does not | ||
provide the ``cp`` command. | ||
- If you haven't installed :term:`Git` yet, please download and install the latest release from `git-scm.com/ <https://git-scm.com/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FTR: Many options are advertised by the git installer. We should leave recommendations, if we have any. Candidates are:
- true type fonts (OMG my eyes can see for the first time on windows)
- msys terminal (stellar C&P performance in comparison)
- credential manager
- FS tuning options (do they have an effect?)
- enable symlinks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to automate, https://github.com/datalad/datalad/issues/5078
After following the installation instructions, and running the git-annex tests I get:
Output is pretty garbled. OK initially (with colors), but then riddled with ASCI control sequences. |
ah shit :/ is that on the computer under your desk? I haven't actually run the git-annex test suite on my Windows computer. But this may be a very useful recommendation to give people a way to judge whether everything is okay |
Those? |
docs/intro/installation.rst
Outdated
|
||
- During installation, you will be prompted to "Choose Install Location". | ||
**Install it into the miniconda Library directory**, e.g. | ||
``C:\Users\me\Miniconda3\Library``. | ||
**Install it into the directory in which Git is installed**, e.g., ``C:\Program Files (x86)\Git``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with 64bit version of git and annex so no x86
docs/intro/installation.rst
Outdated
|
||
- **Step 4**: Install DataLad via pip | ||
|
||
- ``pip`` was installed by ``miniconda``. In the ``Anaconda prompt``, run:: | ||
|
||
pip install datalad~=0.12 | ||
pip install datalad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What not conda install since already using conda
docs/intro/installation.rst
Outdated
|
||
Note: Is has to be from ``conda-forge``, the anaconda version does not | ||
provide the ``cp`` command. | ||
- If you haven't installed :term:`Git` yet, please download and install the latest release from `git-scm.com/ <https://git-scm.com/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to automate, https://github.com/datalad/datalad/issues/5078
@yarikoptic I have updated the installation instructions to "native Git (with TrueType Fonts) + miniconda + conda-forge datalad" for now. I very much support automation, but until then, shall we merge this as a temporary improvement? |
sounds good for now, but you might like to add (unless you already did) a note that
|
Off, I didn't have that solution (using the Git Bash) on my radar at all (I hat Windows so much... its an endless rabbit hole of non-optimal options)! One way I found to make it work was to tick the box to add Miniconda to the PATH variable during Miniconda installation. This terminal does look nicer,
Ahhhhhh crap 🤦 |
Ok, I will merge this now. Its definitely not done, but a huge improvement to the current status. |
I'm working my way through the handbook on Windows and add "Windows-Workaround" Sections where ever necessary. So far, its frequently necessary.