Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Note about asyncio errors and workaround for Jupyter #646

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Conversation

adswa
Copy link
Contributor

@adswa adswa commented Feb 5, 2021

Taking notes from datalad/datalad#5409

adswa and others added 2 commits February 5, 2021 16:40
* Provide problem description along with links to related ipykernel
  and python issues.

* Rewrite bit about nest-asyncio, mostly to avoid saying that the
  workaround is specific to Jupyter.

* Drop one of the errors.  It error looks like it's from DataLad's
  gh-5313, and that should be resolved with 0.14.
@kyleam
Copy link
Contributor

kyleam commented Feb 9, 2021

Thanks @adswa, and sorry I didn't spot this until now. I've pushed a rewrite on top of your commit to kyleam/datalad-handbook:asyncio. If that looks okay to you, feel free to bring it (or any part of it) into this PR.

@adswa
Copy link
Contributor Author

adswa commented Feb 10, 2021

Thanks a lot @kyleam! I like your change much better, its now in this branch.

and sorry I didn't spot this until now.

Sorry, I didn't actually wait for you to spot this, I just quickly wrote it up and then had forgotten to merge it because I got distracted with something else :)

@adswa adswa merged commit 0eb917a into master Feb 10, 2021
@adswa adswa deleted the asyncio branch February 10, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants