Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New boxtype importantnote #662

Merged
merged 7 commits into from
Feb 19, 2021
Merged

New boxtype importantnote #662

merged 7 commits into from
Feb 19, 2021

Conversation

mih
Copy link
Collaborator

@mih mih commented Feb 18, 2021

To replace the regular note directive, with support for all features
of the other boxtypes.

.. importantnote:: <title>

   Content....

image

To replace the regular `note` directive, with support for all features
of the other boxtypes.

```rst
.. importantnote:: <title>

   Content....
```
@adswa
Copy link
Contributor

adswa commented Feb 18, 2021

so much nicer 😍

@adswa
Copy link
Contributor

adswa commented Feb 19, 2021

I just got around to try it now. It looks nice in the PDF, but in HTML, it is a quite bleak, expandable box that hides its contents rather than making aware of something important:
Screenshot from 2021-02-19 14-29-46

@mih
Copy link
Collaborator Author

mih commented Feb 19, 2021

OK, there you go! That is the website now, not (just) the PDF ;-)

image

image

@adswa
Copy link
Contributor

adswa commented Feb 19, 2021

Yay! :) I'll wait for the tests to finish, but its LGTM from my point of view. Really really beautiful :)

@adswa adswa merged commit 37fdfb1 into master Feb 19, 2021
@adswa adswa deleted the important branch February 20, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants