Remove quotes from config file displays #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quotes encompassing values in git config files (including .datalad/config), are not required and in fact inconsequential when being read again via git-config. Showing them when displaying such configs in the handbook may therefore be confusing and leading to the user trying to achieve this, which is not possible via git-config or datalad's python API. This would only be achievable by editing the raw config file w/o a sanitizing interface. Simply remove the depiction of such quotes, as I think debating this aspect only makes the impression that it is somehow important, when really these quotes have no effect at all. (Closes datalad-handbook#688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotes encompassing values in git config files (including
.datalad/config), are not required and in fact inconsequential when
being read again via git-config. Showing them when displaying such
configs in the handbook may therefore be confusing and leading to the
user trying to achieve this, which is not possible via git-config or
datalad's python API. This would only be achievable by editing the raw
config file w/o a sanitizing interface.
Simply remove the depiction of such quotes, as I think debating this
aspect only makes the impression that it is somehow important, when
really these quotes have no effect at all.
(Closes #688)