Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Relative links in sidebar #718

Merged
merged 1 commit into from
May 20, 2021
Merged

ENH: Relative links in sidebar #718

merged 1 commit into from
May 20, 2021

Conversation

effigies
Copy link
Contributor

Found some absolute links that made it hard to find the FAQ in the rendering of #717. Feel free to close without discussion if there's a good reason to use absolute links.

adswa
adswa approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's a good reason to use absolute links.

There is not good reason whatsoever - Thank you!

@adswa adswa merged commit 57bc050 into datalad-handbook:master May 20, 2021
@welcome
Copy link

welcome bot commented May 20, 2021

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@effigies effigies deleted the enh/local_quick_links branch May 20, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adswa adswa adswa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @adswa