Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: GIN siblings - fix typo in code and note that --url should not end with .git #753

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Sep 1, 2021

Fixes these minor issues found in the handbook.

Verified

This commit was signed with the committer’s verified signature.
vjik Sergei Predvoditelev
@welcome
Copy link

welcome bot commented Sep 1, 2021

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Wohoo! 🎉 Thanks for opening your first pull request to the DataLad Handbook! 😎 We really appreciate your time and effort to contribute to the project - you're amazing! 👏

@adswa
Copy link
Contributor

adswa commented Sep 1, 2021

Thanks for catching this, @oesteban!

@mih, I remember this PR came from #706 during the Studyforrest Hackathon, when we created the Gin repos as an alternate datasource in case Juelich's datapub server is offline again at some point. I haven't checked all the studyforrest repos, but I can't find a dataset with a configured special remote to Gin (did we forget to do this somehow?). We maybe want to check if there are datasets configured like this. And if we forgot to configure the datasets, we should probably finally get to it :-)

@all-contributors please add @oesteban for bug .
@oesteban, please feel free to add yourself to the zenodo.json file in the repository.

@allcontributors
Copy link
Contributor

@adswa

I've put up a pull request to add @oesteban! 🎉

@adswa adswa merged commit c90e7ea into datalad-handbook:master Sep 1, 2021
@welcome
Copy link

welcome bot commented Sep 1, 2021

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants