Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containers-add should throw error message when referenced image is outside of dataset #150

Open
jkroell opened this issue Apr 9, 2021 · 1 comment
Open

containers-add should throw error message when referenced image is outside of dataset #150

jkroell opened this issue Apr 9, 2021 · 1 comment

Comments

@jkroell
Copy link

jkroell commented Apr 9, 2021

Running datalad containers-add fMRIprep -i '/data/project/singularity/fmriprep-20.2.0.simg' -d '/data/project/hcp_movies/hcp-openaccess/' did not result in an error even though data/project/singularity/fmriprep-20.2.0.simg does not exist in the dataset.
@bpoldrack
Copy link
Member

Quick remark on that:

It's two issues with not checking the value of -i:

  1. It's supposed to be a relative path within the dataset and apparently we don't check that.
  2. I think -i makes no sense at all, when there's no source for the image given. We don't catch that either.

mih added a commit to mih/datalad-container that referenced this issue Oct 10, 2023
@mih
Add protection against invalid image path declarations for add
2d245c2 
This is a bit painful, because datalad-next parameter validation
is not available, but worth adding given the issue.

Closes datalad#150
@mih mih mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add protection against invalid image path declarations for add mih/datalad-container
2 participants
@bpoldrack @jkroell