Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datalad_container.adapters.docker save assume latest if no image version given #206

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 17, 2023

Closes #105.

@jwodder jwodder added patch Increment the patch version when merged CHANGELOG-missing labels Mar 17, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 17, 2023

Code Climate has analyzed commit 618b9af and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Security 7

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (c3bb747) 93.82% compared to head (618b9af) 93.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   93.82%   93.90%   +0.07%     
==========================================
  Files          19       19              
  Lines         956      968      +12     
==========================================
+ Hits          897      909      +12     
  Misses         59       59              
Impacted Files Coverage Δ
datalad_container/adapters/docker.py 86.60% <100.00%> (+0.24%) ⬆️
datalad_container/adapters/tests/test_docker.py 95.18% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If tests pass -- can be merged

@jwodder jwodder merged commit b0532e1 into master Mar 17, 2023
@jwodder jwodder deleted the gh-105b branch March 17, 2023 20:15
@github-actions
Copy link

PR released in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker adapter: Provide better handling of non-unique references
2 participants