Support {python} placeholder

[mih]

This placeholder is expanded on execution of a container, rather than on configuration/addition. This helps use the same Python installation that is also executing the datalad-container code.

Previously, the docker-support code would expand and then hardcode sys.executable on configuring a container. This led to non-portable configuration (e.g., hardcoded python.exe on windows), and would fail to pick up the correct python installation in any case where the python entrypoint would not point to the correct one.

Closes #226
Almost does #224 (missing the platform path issue)

[codeclimate]

Code Climate has analyzed commit 3fc0079 and detected 0 issues on this pull request.

View more on Code Climate.

[adswa]

The failures are due to dockerhubs rate limiting:

toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

[mih]

@adswa Yeah, the test setup is not so nice. Locally this works now -- also on windows.

[adswa]

looks sensible to me

[yarikoptic]

any idea on how many tests would fail if windows is added as a test env?

[mih]

any idea on how many tests would fail if windows is added as a test env?

When I execute the tests on windows (minus anything metalad-related datalad/datalad-metalad#397 because I am working with PY3.12 right now), I see 8 failed, 13 passed.

A good chunk of the failures is simply #233, most of the rest is wrong path assumptions.

[mih]

Rebased after merge of #235

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4782a7a) 94.59% compared to head (3fc0079) 94.59%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          25       25           
  Lines        1091     1092    +1     
=======================================
+ Hits         1032     1033    +1     
  Misses         59       59           

Files	Coverage Δ
datalad_container/containers_add.py	89.67% <100.00%> (ø)
datalad_container/containers_run.py	84.84% <100.00%> (+0.23%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mih]

Merging, given the approvals.