Replace custom configuration definition with standard approach #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v0.16 datalad provides a `register_config()` helper for extensions
to inject their own configuration into the central registry.
This changeset replaces the previous custom implementation with this
standard approach. It has not consequences re user behavior.
An additional benefit is that this configuration is now also
user-accessible, including a basic documentation:
```py
>>> import datalad_container
>>> from datalad.api import configuration
>>> configuration('dump', 'datalad.containers.location')
datalad.containers.location=.datalad/environments
[{'action': 'dump_configuration',
'refds': '/home/mih/hacking/datalad/container',
'name': 'datalad.containers.location',
'value': '.datalad/environments',
'purpose': 'Container location',
'description': 'path within the dataset where to store containers',
'value_type': constraint:str,
'path': '/home/mih/hacking/datalad/container',
'status': 'ok'}]
```
Closes datalad#239
|
Code Climate has analyzed commit 8ca639e and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 25 24 -1
Lines 1104 1104
=======================================
Hits 1046 1046
Misses 58 58
☔ View full report in Codecov by Sentry. |
mih
added a commit
to mih/datalad-container
that referenced
this pull request
Oct 12, 2023
This causes worse portability issues than the previous approach of storing `python(.exe)`. Instead pass the placeholder on to `datalad run`. This would now error with ``` command has an unrecognized placeholder: 'python' ``` and requires a further intervention. Three options: - have datalad-core define `datalad.run.substitutions.python=sys.executable` - wait for datalad#244 and use `register_config()` to have datalad-container define it - have datalad-container define it at `containers-run` runtime by patching the configuration for the execution time (would have `rerun` fail still) - add the configuration item to the committed dataset config Closes datalad#249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.16 datalad provides a
register_config()helper for extensions to inject their own configuration into the central registry.This changeset replaces the previous custom implementation with this standard approach. It has not consequences re user behavior.
An additional benefit is that this configuration is now also user-accessible, including a basic documentation:
Closes #239