Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for now missing setuptools which are used in setup.py #255

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Workaround for now missing setuptools which are used in setup.py #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
pypi-token: ${{ secrets.PYPI_TOKEN }}
pre-tag: |
pip install setuptools # needed for setup.py --version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarikoptic This is for setup.py --name, not setup.py --version (which you're not doing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang... right... damn suggestions in pycharm... will all be gone with hardcoding...

pkg="$(python setup.py --name)"
printf '__version__ = "%s"\n' "$new_version" > "$pkg"/version.py
git commit -m "Update __version__ to $new_version" "$pkg"/version.py
Expand Down
Loading