BF: move check for metalad before import of meta_extract #257
Conversation
Otherwise we try to import meta_extract and it fails. Failed the build of datalad-container for debian
|
Code Climate has analyzed commit be5f9e1 and detected 0 issues on this pull request. View more on Code Climate. |
yarikoptic
force-pushed
the
bf-metalad-import
branch
from
dc25ae8 to
be5f9e1
Compare
| Dataset, | ||
| clone, |
There was a problem hiding this comment.
Is there a convention to import classes first? I've always just done strictly alphabetical
There was a problem hiding this comment.
"not sure". Please find an answer at https://pycqa.github.io/isort/docs/configuration/custom_sections_and_ordering.html somewhere or may be @jwodder could clarify?
There was a problem hiding this comment.
isort does sort by case
https://pycqa.github.io/isort/docs/configuration/options.html
Order imports by type, which is determined by case, in addition to alphabetically.
NOTE: type here refers to the implied type from the import name capitalization. isort does not do type introspection for the imports. These "types" are simply: CONSTANT_VARIABLE, CamelCaseClass, variable_or_function. If your project follows PEP8 or a related coding standard and has many imports this is a good default, otherwise you likely will want to turn it off. From the CLI the --dont-order-by-type option will turn this off.
Type: Bool
Default: True
Config default: true
Python & Config File Name: order_by_type
CLI Flags:
--ot
--order-by-type
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 24 24
Lines 1133 1134 +1
=======================================
+ Hits 1073 1074 +1
Misses 60 60 ☔ View full report in Codecov by Sentry. |
|
releasing so we simplify update of packages for debian and conda-forge both of which need this now |
Otherwise we try to import meta_extract and it fails. Failed the build of datalad-container for debian
I will shortly bundle also run of isort on that file to ensure that pragmas are effective