Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/tools: Add fuse2fs dependency for singularity installation #264

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

adswa
Copy link
Member

@adswa adswa commented Feb 2, 2024

Should provide a fix for #263

@adswa
Copy link
Member Author

adswa commented Feb 2, 2024

The singularity installation succeeds now.
There is a test failure, but I don't think it needs addressing in this PR:

============================================================================================================
FAILED ../adapters/tests/test_docker.py::test_load_multi_image - datalad.runner.exception.CommandError: CommandError: 'docker pull alpine:3.15' failed with exitcode 1
======================================================================================= 1 failed, 28 passed, 

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49d30bc) 94.64% compared to head (52eefbd) 94.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          24       24           
  Lines        1120     1120           
=======================================
  Hits         1060     1060           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

I restarted that appveyor run -- apparently was some intermittent failure, so we are all good. I do not think we need a release for it but I could be proven to be wrong ;)

@yarikoptic yarikoptic merged commit c204331 into datalad:master Feb 2, 2024
6 of 7 checks passed
@yarikoptic yarikoptic added the tests Add or improve existing tests label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants