ENH: add: Copy local files instead of transforming them to a URL #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of git-annex 6.20180626, using a local file as the argument to --url will fail with the default configuration for annex.security.allowed-url-schemes. Adding a local image is primarily done for testing purposes, and pointing to a local URL doesn't provide much of a benefit, so just copy it instead. If a user wants to treat a local path as a URL, they can still specify it with 'file://'. Closes datalad#47.
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 78.24% 79.46% +1.22%
==========================================
Files 12 12
Lines 432 448 +16
==========================================
+ Hits 338 356 +18
+ Misses 94 92 -2
Continue to review full report at Codecov.
|
yarikoptic
reviewed
Oct 26, 2018
jsheunis
pushed a commit
that referenced
this pull request
Nov 6, 2023
adswa
pushed a commit
to adswa/datalad-container
that referenced
this pull request
Nov 8, 2023
For uber-reproducibility - make zoneinfo always be UTC inside the container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of git-annex 6.20180626, using a local file as the argument to
--url will fail with the default configuration for
annex.security.allowed-url-schemes. Adding a local image is primarily
done for testing purposes, and pointing to a local URL doesn't provide
much of a benefit, so just copy it instead. If a user wants to treat
a local path as a URL, they can still specify it with 'file://'.
Closes #47.