Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: remove datalad_deprecated dependency #119

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

yarikoptic
Copy link
Member

Was introduced in #94
with only hypothetical assumptions of the necessity. We are now hypothesizing
that it was not needed

Was introduced in datalad#94
with only hypothetical assumptions of the necessity.  We are now hypothesizing
that it was not needed
@yarikoptic yarikoptic added the internal Changes only affect the internal API label Aug 3, 2022
@yarikoptic
Copy link
Member Author

it wasn't hypothetical -- it was indeed due to use of ls:

______ ERROR collecting datalad_crawler/pipelines/tests/test_openfmri.py _______
ImportError while importing test module '/home/travis/build/datalad/datalad-crawler/datalad_crawler/pipelines/tests/test_openfmri.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../virtualenv/python3.7.1/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
datalad_crawler/pipelines/tests/test_openfmri.py:61: in <module>
    from .. import openfmri
datalad_crawler/pipelines/openfmri.py:29: in <module>
    from datalad.api import ls
E   ImportError: cannot import name 'ls' from 'datalad.api' (/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/datalad/api.py)
_ ERROR collecting datalad_crawler/pipelines/tests/test_openfmri_collection.py _
ImportError while importing test module '/home/travis/build/datalad/datalad-crawler/datalad_crawler/pipelines/tests/test_openfmri_collection.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../virtualenv/python3.7.1/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
datalad_crawler/pipelines/tests/test_openfmri_collection.py:37: in <module>
    from ..openfmri import superdataset_pipeline as ofcpipeline
datalad_crawler/pipelines/openfmri.py:29: in <module>
    from datalad.api import ls
E   ImportError: cannot import name 'ls' from 'datalad.api' (/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/datalad/api.py)
________ ERROR collecting datalad_crawler/pipelines/tests/test_xnat.py _________
ImportError while importing test module '/home/travis/build/datalad/datalad-crawler/datalad_crawler/pipelines/tests/test_xnat.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../virtualenv/python3.7.1/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
datalad_crawler/pipelines/tests/test_xnat.py:56: in <module>
    from ..xnat import XNATServer
datalad_crawler/pipelines/xnat.py:43: in <module>
    from datalad.api import ls
E   ImportError: cannot import name 'ls' from 'datalad.api' (/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/datalad/api.py)
=========================== short test summary info ============================
ERROR datalad_crawler/pipelines/tests/test_openfmri.py
ERROR datalad_crawler/pipelines/tests/test_openfmri_collection.py
ERROR datalad_crawler/pipelines/tests/test_xnat.py
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!

fixing that

All of that is not really needed any more since openneuro is "no more" needed
to be crawled - uses git-annex natively
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #119 (d444b19) into master (53121d7) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   77.68%   77.64%   -0.05%     
==========================================
  Files          60       60              
  Lines        4710     4692      -18     
  Branches      699      699              
==========================================
- Hits         3659     3643      -16     
+ Misses        887      885       -2     
  Partials      164      164              
Impacted Files Coverage Δ
datalad_crawler/pipelines/xnat.py 17.68% <ø> (-8.15%) ⬇️
datalad_crawler/pipelines/openfmri.py 84.74% <66.66%> (+3.38%) ⬆️
datalad_crawler/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yarikoptic
Copy link
Member Author

green is good.

@yarikoptic yarikoptic merged commit 3ba80aa into datalad:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant