Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-sibling-dataverse CLI broken #289

Closed
mih opened this issue Apr 7, 2023 · 0 comments · Fixed by #290
Closed

add-sibling-dataverse CLI broken #289

mih opened this issue Apr 7, 2023 · 0 comments · Fixed by #290

Comments

@mih
Copy link
Member

mih commented Apr 7, 2023

Any call gives

[ERROR  ] AddSiblingDataverse.__call__() missing 1 required positional argument: 'ds_pid'

this is the fix:

diff --git a/datalad_dataverse/add_sibling_dataverse.py b/datalad_dataverse/add_sibling_dataverse.py
index cb6e21f..b505907 100644
--- a/datalad_dataverse/add_sibling_dataverse.py
+++ b/datalad_dataverse/add_sibling_dataverse.py
@@ -98,7 +98,8 @@ class AddSiblingDataverse(ValidatedInterface):
             doc="""URL identifying the dataverse instance to connect to
             (e.g., https://demo.dataverse.org)""",),
         ds_pid=Parameter(
-            args=("PID",),
+            args=("ds_pid",),
+            metavar=("PID",),
             doc="""Persistent identifier of the dataverse dataset to
             use as a sibling. This PID can be found on the dataset's
             landing page on Dataverse. Either right at the top
mih added a commit that referenced this issue Apr 7, 2023
Got broken in 1f995f6 in what seems to
be an attempt to alter the display of positional args.

Closes #289
mih added a commit that referenced this issue Apr 7, 2023
Got broken in 1f995f6 in what seems to
be an attempt to alter the display of positional args.

Closes #289
@mih mih closed this as completed in #290 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant