Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and execute standard messaging/error reporting pattern #48

Open
mih opened this issue Jun 17, 2022 · 3 comments
Open

Define and execute standard messaging/error reporting pattern #48

mih opened this issue Jun 17, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@mih
Copy link
Member

mih commented Jun 17, 2022

SpecialRemote.meassage() maybe? @bpoldrack ?

@bpoldrack
Copy link
Member

bpoldrack commented Jun 17, 2022

Actual errors should be exceptions if suitable, I think. TheSpecialRemote is taking care of turning them into ERROR messages to annex. This allows to also get a traceback not just a single message.

Otherwise, yes: That's what SpecialRemote.message() is for. Note, that if you actually send an type=error message, this is supposed to end the process IIRC. Hence, exception is also more intuitive when reading the code.

@mih
Copy link
Member Author

mih commented Jun 17, 2022

ok, thx. I don't think getting tracebacks is desirable in standard cases. For example, authentication is invalid: I would want to get a clear message saying exactly that, not a traceback.

@mih
Copy link
Member Author

mih commented Jul 4, 2022

This issue still require someone to check the code base an confirm a homogeneous and valid messaging pattern to be used.

@mih mih added the enhancement New feature or request label Jul 7, 2022
mih added a commit to mih/datalad-dataverse that referenced this issue Feb 28, 2023
Templates for using datalad/release-action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants