Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMP: Check for remaining test failures #328

Closed
wants to merge 5 commits into from
Closed

TMP: Check for remaining test failures #328

wants to merge 5 commits into from

Conversation

adswa
Copy link
Member

@adswa adswa commented Sep 5, 2024

this temporarily merged the two open test-modifying PR branches, and depends on bleeding edge dataverse. Hopefully, this resolves remaining test failures - otherwise, we know what else to fix before a release.

@adswa
Copy link
Member Author

adswa commented Sep 5, 2024

oh well...

Commit "65c2696e" of branch "tmp" skipped as commit files did not match "only_commits.files"

@adswa
Copy link
Member Author

adswa commented Sep 5, 2024

Appveyor tests run through, but they're marked as a failure because of a codecov error on Mac:

Running "after_test" scripts
python -m coverage xml
Wrote XML report to coverage.xml
curl -Os $CODECOV_BINARY
chmod +x codecov
./codecov
/usr/local/Cellar/appveyor-build-agent/7.0.3293/bash-shell.sh: line 51: ./codecov: Bad CPU type in executable
Command exited with code 126
Running "on_finish" scripts
while [ -f ~/BLOCK ]; do sleep 5; done

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (fbc0e0e) to head (607b962).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   93.78%   93.44%   -0.34%     
==========================================
  Files          17       17              
  Lines         965      977      +12     
==========================================
+ Hits          905      913       +8     
- Misses         60       64       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adswa adswa closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants