Add external links to files (if available) and display in context menu #37
Conversation
|
Ok, did some more testing using tpl-Fischer344, the web UI portion seems to be working. However, I haven't done a full test, as in one smooth process from "datalad create-sibling" then doing "datalad push" yet. I've just been copying over the updated metadata file from my updated "datalad ls" over -- I think I'll need to integrate my updated "datalad ls" into "datalad push" somehow for that full test, I'll look into it! (The attached photos show what it looks like when there's only 1 external URL and multiple external URLs. If there's multiple, it displays a max of 5 and lists each with their hostname)
|
|
Sorry for the delay, but I've been able to test a full create-sibling to push process using the latest datalad version (15.01), and got the external_urls going as shown above. |
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
|
@yarikoptic what are your plans here? Put in draft mode? |
|
I am putting this PR in draft mode. |
|
thanks @mih . I think changes are LGTM, I might try to find some time to test myself and deploy and merge then. |
|
after #51 is merged, I will merge master into this and ensure it breaks nothing and merge then |
datalad_deprecated/ls_webui.py
Outdated
| import datalad.api as dl | ||
|
|
||
| # remove the below 2 lines when NEEDS_CONTENT is already made false | ||
| import datalad.metadata.extractors.datalad_core as dc |
There was a problem hiding this comment.
Actually I will adjust this part since we already moved that etc
* origin/master: (79 commits) Update CHANGELOG.md [skip ci] After moving with_testrepos here, also move its tests Adjust import of with_testrepo to local module Absorb with_testrepos and studyforrest_mockup functionality Update CHANGELOG.md [skip ci] Add deprecated metadata config procedure from datalad core Update CHANGELOG.md [skip ci] List metadata commands in README Adjust imports for metadata move BF: Fix annotate path imports Update CHANGELOG.md [skip ci] use splitlines to improve behavior in multi-OS env reformat code to take advantage of paranthesis adapt to new changes in datalad master Update CHANGELOG.md [skip ci] ENH: tune up testing infrastructure BF(TST): make it ok to have no "notneeded" in publish test Configure Dependabot to update GitHub Actions action versions Update GitHub Actions action versions Update CHANGELOG.md [skip ci] ...
…ted too by now
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi 'import datalad.metadata' 'import datalad_deprecated.metadata'",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
|
eh, crippled fs fail seems related to the changes in PR so will need to get closer look |
|
Appveyor Mac fail is unrelated IMHO |
|
🚀 PR was released in |
Not finished, just adding a pr to keep track of progress.
Currently, the code adds an "external_urls" property that contains a list of external URLs to file metadata, but this has only been tested on a small dataset (templateflow's tpl-Fischer344).
Still need to do more testing and implement it on the webui side.