Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CONTRIBUTORS file as well as references to it #87

Closed
wants to merge 1 commit into from

Conversation

jsheunis
Copy link
Member

@jsheunis jsheunis commented Oct 9, 2023

Updates:

  • CONTRIBUTORS
  • MANIFEST.in

Closes #84

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (81dcfe5) 92.68% compared to head (3dfc2ca) 92.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files           5        5           
  Lines          41       41           
=======================================
  Hits           38       38           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adswa
Copy link
Member

adswa commented Oct 9, 2023

I have voiced a few reasons against this PR in the original issue.
In summary, these were:

  • the fact that it is unused makes sense insofar that this is a template for others to use
  • it is standard practice to include it in python packages according to the popular cookiecutter template, and GitHub includes this file in its list of community guidelines (a checklist projects can fulfill in their settings that aims to promote community-orientation in projects)

@mslw
Copy link
Contributor

mslw commented Oct 9, 2023

I understand where the PR is coming from in that the contributors file is unused (or rather: not used actively, i.e. not updated) across several DataLad projects, including core (3 yrs ago) and next, where zenodo.json became the de facto contributor list.

But the arguments presented by @adswa are compelling, and I would vote to keep the file in the template.

@adswa
Copy link
Member

adswa commented Oct 10, 2023

In the spirit of not leaving forgotten clutter around, I'll close this PR - but if there are new viewpoints that speak for this PR, let's reopen this and rekindle the discussion.

@adswa adswa closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CONTRIBUTORS file
3 participants