Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #167

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fix failing tests #167

merged 2 commits into from
Jun 19, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 16, 2023

Closes #166.

@jwodder jwodder added the tests Add or improve existing tests label Jun 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.94 🎉

Comparison is base (f2f1727) 63.67% compared to head (4cd4d29) 64.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   63.67%   64.62%   +0.94%     
==========================================
  Files           1        1              
  Lines        1481     1484       +3     
  Branches      342      343       +1     
==========================================
+ Hits          943      959      +16     
+ Misses        447      431      -16     
- Partials       91       94       +3     
Impacted Files Coverage Δ
src/datalad_installer.py 64.62% <100.00%> (+0.94%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -28,7 +28,8 @@ jobs:
- '3.9'
- '3.10'
- '3.11'
- 'pypy-3.7'
- 'pypy-3.8'
- 'pypy-3.9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if related but I also asked bot to renew conda-forge/datalad-feedstock#101

@jwodder jwodder changed the title Update PyPy versions tested against Fix failing tests Jun 19, 2023
@jwodder jwodder marked this pull request as ready for review June 19, 2023 14:37
@yarikoptic
Copy link
Member

Great, thank you!

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jun 19, 2023
@yarikoptic yarikoptic merged commit 5fec63b into master Jun 19, 2023
@yarikoptic yarikoptic deleted the gh-166 branch June 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI had been failing (for ubuntus?) for quite a while
3 participants