Extend miniconda docstring on how to figure out VERSION to use #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the clarification, this helps a lot! (But this addition broke tests). |
This way we could still have long description printed in command --help
jwodder
requested changes
Jul 5, 2023
| @@ -823,7 +823,7 @@ def long_help(cls, progname: str, component: Optional[str] = None) -> str: | |||
| width = max(map(len, cls.COMPONENTS.keys())) | |||
| for name, cmpnt in sorted(cls.COMPONENTS.items()): | |||
| if cmpnt.OPTION_PARSER.help is not None: | |||
| chelp = cmpnt.OPTION_PARSER.help | |||
| chelp = cmpnt.OPTION_PARSER.help.splitlines()[0] | |||
There was a problem hiding this comment.
What's the point of this change?
There was a problem hiding this comment.
so that in datalad-installer --help we have only the first line listed. Without this I get
❯ src/datalad_installer.py --help
...
miniconda Install Miniconda VERSION is the version [...]
Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
jwodder
approved these changes
Jul 5, 2023
|
it seems some tests are failing of an error which is due to installation of really outdated datalad 0.9.x File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/cmdline/main.py", line 291, in main
parser = setup_parser()
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/cmdline/main.py", line 73, in setup_parser
from ..interface.base import dedent_docstring, get_interface_groups, \
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/interface/base.py", line 27, in <module>
from datalad.interface.common_opts import eval_params
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/interface/common_opts.py", line 15, in <module>
from datalad.interface.results import known_result_xfms
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/interface/results.py", line 27, in <module>
from datalad.distribution.dataset import Dataset
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/distribution/dataset.py", line 30, in <module>
from datalad.support.annexrepo import AnnexRepo
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/support/annexrepo.py", line 63, in <module>
from .gitrepo import GitRepo
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/support/gitrepo.py", line 414, in <module>
class GitRepo(RepoInterface):
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/support/gitrepo.py", line 860, in GitRepo
def add(self, files, commit=False, msg=None, git=True, git_options=None,
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/utils.py", line 600, in intermediator
return to_be_wrapper(*args, **kwargs)
File "/tmp/pytest-of-runner/pytest-0/test_install_venv_miniconda_da0/conda/lib/python3.10/site-packages/datalad/utils.py", line 623, in wrapper
is_decorating = not kwargs and len(args) == 1 and isinstance(args[0], collections.Callable)
AttributeError: module 'collections' has no attribute 'Callable'on which I provided some details in conda-forge/datalad-feedstock#109 but have not come up with a solution. @jwodder -- do you see how to address it or workaround by any chance? |
|
ok, for now -- let's merge since all those failed ones do not relate to this PR changes |
yarikoptic
added a commit
that referenced
this pull request
Aug 22, 2023
…tests would still consistently fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggered by @adswa 's question in matrix