Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type-checking of imports #179

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Improve type-checking of imports #179

merged 1 commit into from
Nov 8, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.80%. Comparing base (b88f21a) to head (5ae8de1).
Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   65.06%   64.80%   -0.27%     
==========================================
  Files           1        1              
  Lines        1500     1500              
  Branches      346      346              
==========================================
- Hits          976      972       -4     
- Misses        429      431       +2     
- Partials       95       97       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -28,6 +28,7 @@ commands =
[testenv:typing]
deps =
mypy
{[testenv]deps}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with this syntax, could you please digest it for me?

Copy link
Member Author

@jwodder jwodder Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tox-specific syntax that causes all deps listed in the [testenv] environment (i.e., all of our test dependencies) to be included in the deps for the typing environment. This is necessary for mypy to be able to type-check test code that uses dependencies like pytest.

@yarikoptic yarikoptic merged commit aab966e into master Nov 8, 2023
23 of 24 checks passed
@yarikoptic yarikoptic deleted the check-imports branch November 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants