Convert almost all classes to dataclasses #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
added
release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 64.49% 65.00% +0.50%
==========================================
Files 1 1
Lines 1611 1620 +9
Branches 374 402 +28
==========================================
+ Hits 1039 1053 +14
+ Misses 470 466 -4
+ Partials 102 101 -1
☔ View full report in Codecov by Sentry. |
yarikoptic
reviewed
Nov 13, 2023
| #: method | ||
| #: A list of files to which to write ``PATH`` modifications and related | ||
| #: shell commands | ||
| env_write_files: list[Path] = field(default_factory=list) |
There was a problem hiding this comment.
how they will become Path here if str would be provided? (I just don't see any relevant changes in this diff)
There was a problem hiding this comment.
DataladInstaller is never actually initialized with an explicit env_write_files argument, so it doesn't matter. (I guess it mattered in some older version of the script?)
|
@yarikoptic Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes the code a little bit more efficient in some places, but it also provides us with a PR to release on.