Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide -y to apt-get install #194

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Always provide -y to apt-get install #194

merged 1 commit into from
Feb 16, 2024

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Feb 16, 2024

Ref: workaround was attempted at https://github.com/neuronets/datalad-action/pull/1/files

Origin: trying to use datalad-installer on a pristine'ish Debian AMI on AWS.

note: next aspect is that while trying on that AMI -- it failed to install because there were no prior apt-get update run and some package information was outdated. But it is a separate issue

Ref: workaround was attempted at https://github.com/neuronets/datalad-action/pull/1/files

Origin: trying to use datalad-installer on a pristine'ish Debian AMI on
AWS.
@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2196b1b) 65.57% compared to head (0fc1b1d) 65.57%.

Files Patch % Lines
src/datalad_installer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   65.57%   65.57%           
=======================================
  Files           1        1           
  Lines        1644     1644           
  Branches      408      408           
=======================================
  Hits         1078     1078           
  Misses        466      466           
  Partials      100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit 45655a6 into master Feb 16, 2024
32 checks passed
@yarikoptic yarikoptic deleted the bf-apt-install branch February 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants