run-tests.sh: Get GitHub token from gh if envvar not set
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 65.77% 65.53% -0.25%
==========================================
Files 1 1
Lines 1648 1648
Branches 409 409
==========================================
- Hits 1084 1080 -4
- Misses 460 465 +5
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. |
|
what is this solving? NB windows tests seems to generally fail ATM, unrelated to this PR |
I want to stop storing my GitHub token under |
|
FWIW could be stored in external file and "included" within ~/.gitconfig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.