Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State by what component a system is not supported in a generic message #215

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

yarikoptic
Copy link
Member

Otherwise it is hard to impossible (line numbers no longer match, pain) to determine who is complaining and why in a complex invocation composition

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Dec 13, 2024
@yarikoptic yarikoptic requested a review from jwodder December 13, 2024 16:56
@yarikoptic yarikoptic changed the title [DATALAD RUNCMD] State by what a system is not supported in a generic message State by what component a system is not supported in a generic message Dec 13, 2024
src/datalad_installer.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (db49453) to head (a5cf335).

Files with missing lines Patch % Lines
src/datalad_installer.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   65.08%   64.30%   -0.78%     
==========================================
  Files           1        1              
  Lines        1667     1667              
  Branches      290      290              
==========================================
- Hits         1085     1072      -13     
- Misses        479      492      +13     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… message

Otherwise it is hard to impossible (line numbers no longer match, pain)
to determine who is complaining and why in a complex invocation composition

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi '{{SYSTEM}} OS not supported' '{{SYSTEM}} OS not supported by {{self.NAME}}'",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic merged commit 0001c4c into master Dec 13, 2024
25 checks passed
@yarikoptic yarikoptic deleted the enh-msg branch December 13, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants