-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iter_gitworktree()
too slow
#540
Comments
Looking at the runtime impact of code components. Using my normal 36k file test case (which has a few thousand untracked files too). Baseline with the code of f2a6fe is ~300ms. Making If Adding back the line It seems that |
In #540 I found about ~10% of the runtime to be attributable to the regex-matching. This patch replaces the regex with two split() calls. In local benchmarks I see a ~10% speedup. One major other source of slow-down was/is the construction of `PurePosixPath` objects. It seems this is being taken care of by python/cpython#101362 and will be resolved eventually. Closes #540
See #539 (comment) for the benchmark.
The text was updated successfully, but these errors were encountered: