Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datalad_next.utils.ParamDictator #610

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Fix datalad_next.utils.ParamDictator #610

merged 2 commits into from
Jan 29, 2024

Conversation

christian-monch
Copy link
Contributor

@christian-monch christian-monch commented Jan 29, 2024 •
edited
Loading

Fixes #609

Adds a regression test for datalad_next.utils.ParamDictator.

@christian-monch
fix ParamDictator
826da6e 
This commit fixes a problem where
`ParamDictator` tries to call the
method `__getattr__`  on an
`object`-instance. `object` does not
provide `__getattr__`, only
`__getattribute__`.

The commit adds a regression test.
@christian-monch christian-monch requested a review from mih as a code owner January 29, 2024 08:53
mih
mih reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this class is not used at all. I'd be in favor of removing it. WDYT?

We would apply this fix regardless for now.

@christian-monch
Copy link
Contributor Author

I don't mind removing it. But I would also do that at a later stage and merge this branch containing the fix for now. Especially because it also fixes the "pytest-deprecation" error in datalad_next.utils.tests.test_deprecated (the fix was done in this PR because it is required for a green appveyor result).

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3aa473b) 92.92% compared to head (4998b93) 92.97%.

Files Patch % Lines
datalad_next/utils/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   92.92%   92.97%   +0.05%     
==========================================
  Files         159      160       +1     
  Lines       11853    11863      +10     
  Branches     1794     1795       +1     
==========================================
+ Hits        11014    11030      +16     
+ Misses        651      643       -8     
- Partials      188      190       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-monch christian-monch requested a review from mih January 29, 2024 10:35
@christian-monch
Copy link
Contributor Author

christian-monch commented Jan 29, 2024 •
edited
Loading

To get this quickly done, let's agree to do one of the following:

  1. merge the branch in its current state
  2. add a commit that removes ParamDictator and merge the branch then

WDYT?

@mih mih merged commit 3d0c8a4 into datalad:main Jan 29, 2024
8 checks passed
@mih
Copy link
Member

mih commented Jan 29, 2024

Done. Tracking with #611

@christian-monch christian-monch deleted the fix-paramdictator branch January 29, 2024 13:13
@mih mih modified the milestones: 1.1.1, 1.2 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mih mih Awaiting requested review from mih mih is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Fix datalad_next.utils.ParamDictator
2 participants
@christian-monch @mih