Adjust appveyor setup for SSH private key declaration #60
Comments
mih
added a commit
that referenced
this issue
Sep 13, 2023
This should be easier to use. The old implementation is now available in `ria_sshserver_setup` and should be considered internal. The new fixture returns the base RIA URL, and a local path to that same root directory (if one exists). It also sets `DATALAD_SSH_IDENTITYFILE`, which is needed by datalad-core's `SSHManager`. The setup may still need to use the `datalad_cfg` fixture, and possibly a dedicated reload to be effective. Closes #60
mih
added a commit
that referenced
this issue
Sep 13, 2023
This should be easier to use. The old implementation is now available in `ria_sshserver_setup` and should be considered internal. The new fixture returns the base RIA URL, and a local path to that same root directory (if one exists). It also sets `DATALAD_SSH_IDENTITYFILE`, which is needed by datalad-core's `SSHManager`. The setup may still need to use the `datalad_cfg` fixture, and possibly a dedicated reload to be effective. Closes #60
mih
added a commit
that referenced
this issue
Sep 20, 2023
This should be easier to use. The old implementation is now available in `ria_sshserver_setup` and should be considered internal. The new fixture returns the base RIA URL, and a local path to that same root directory (if one exists). It also sets `DATALAD_SSH_IDENTITYFILE`, which is needed by datalad-core's `SSHManager`. The setup may still need to use the `datalad_cfg` fixture, and possibly a dedicated reload to be effective. Closes #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The ORA remote uses the datalad-core
SSHManager. Apart from the complexity of OpenSSH deciding how to connect to a server, it adds support for the config settingdatalad.ssh.identityfile. This is not only passed tossh(overwriting any matching setting in its own host-based configuration), but is also used to determine an identifier for the socket name of a multiplex SSH connection (control master).At present the test fixture recognized
DATALAD_TESTS_RIA_SERVER_SSH_PATHfor declaring a private key. The difference is, however, thatdatalad.ssh.identityfileapplies to ANY connection. Declaring it for the entire runtime of the test battery will limit any SSH connection to this single key. This may be tolerable, but is certainly awkward.I am thinking to complement the session-scope fixture
ria_sshserverwith a function-scope fixture that declaresDATALAD_SSH_IDENTITYFILEbased on the effective private key setup for the tests. This should limit the impact to individual tests only.The text was updated successfully, but these errors were encountered: